Ensure partitioning is consistent accross message bus and queue #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra17
force-pushed
the
fix-consistent-partitionning
branch
from
2c68f59 to
1da2d73
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 70.11% 70.14% +0.03%
==========================================
Files 68 68
Lines 4718 4733 +15
Branches 632 629 -3
==========================================
+ Hits 3308 3320 +12
- Misses 1273 1275 +2
- Partials 137 138 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current partitioning scheme cannot be easily customized and is inconsistent throughout the code base. For instance, the DBWorker might be use fingerprint partitioning while the queue is actually partitioned by the hostname (And can't be change to do otherwise). In my case, I have multiples spider partition, partitioned by fingerprint, but the Queue end up partitioning everything in a single partition based on the hostname. So unless a spider from this partition ask for a batch, the other spiders will keep receiving empty batches.
This PR does add two settings:
SPIDER_FEED_PARTIONERandSPIDER_LOG_PARTITIONER. This way users can switch from fingerprint or hostname partitioning. It also let them create their own custom partitioner.QUEUE_HOSTNAME_PARTITIONINGhas been deprecated sinceSPIDER_FEED_PARTIONERcan be used instead.