Add support for “post requests and data” when integrating scrapy. #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve the bug for “wrong request data in metadata” when response updates metadata.
|
Hi @CN-hanyi thank you for your PR! Would be great to have a tests passing and to propagate your changes to all backends: Memory, HBase, MessageBus. Probably it's also worth to check if it needs to be mentioned in docs. |
propagate this change to all backends: memory, hbase,redis . propagate this change to json codecs Add MessageBusBackend test for new codecs(json and msgpack) Fix some bugs after the test.
|
Thanks for your reply. I have added the test for the submitted code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for “post requests and data” when integrating scrapy.
Resolve the bug for “wrong request data in metadata” when response updates metadata.