Fix sqlalchemy queue component partition_id #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix @jpbalarini ! |
|
@sibiryakov what do you think? |
jpbalarini
force-pushed
the
bug/fix_queue_partition
branch
from
7af4e1c to
c36b645
Compare
|
@sibiryakov what do you think of these changes? Adding them will fix the case when someone disables hostname partitioning (my case) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the partition id was always set to 0 when disabling the
QUEUE_HOSTNAME_PARTITIONINGsetting, using a sqlalchemy backend. The problem was that theschedulemethod on theQueuecomponent was always using thehostnameas the partitioning key (independent of theQUEUE_HOSTNAME_PARTITIONINGsetting).Also added a quick description of the
QUEUE_HOSTNAME_PARTITIONINGsetting for the documentation (since it was missing).Thanks!