Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing issues for typed Scrapy. #166

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Fix typing issues for typed Scrapy. #166

merged 10 commits into from
Nov 4, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Sep 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (bbffb57) to head (3b234c0).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   84.23%   86.97%   +2.74%     
==========================================
  Files          15       15              
  Lines         926      960      +34     
==========================================
+ Hits          780      835      +55     
+ Misses        146      125      -21     
Files with missing lines Coverage Δ
scrapy_poet/downloadermiddlewares.py 98.59% <100.00%> (+18.26%) ⬆️
scrapy_poet/injection.py 98.80% <100.00%> (+1.05%) ⬆️
scrapy_poet/page_input_providers.py 98.61% <100.00%> (+0.01%) ⬆️
scrapy_poet/spidermiddlewares.py 100.00% <100.00%> (ø)
scrapy_poet/utils/__init__.py 97.82% <100.00%> (+4.34%) ⬆️
scrapy_poet/utils/testing.py 80.51% <ø> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

@wRAR wRAR marked this pull request as draft September 21, 2023 16:59
@wRAR wRAR marked this pull request as ready for review November 4, 2024 09:05
@Gallaecio Gallaecio merged commit 44a9591 into master Nov 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants