Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpRequestProvider #173

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 16, 2023

To mirror response counterparts, I only implemented a provider for HttpRequest, and not for HttpRequestBody or HttpRequestHeaders. Is that OK, or should we provide more granular providers? It would be trivial to do, but if we do I wonder if I should do the same with response page input classes as well.

To-do:

@Gallaecio Gallaecio requested review from kmike, wRAR and BurnzZ November 16, 2023 08:52
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #173 (db2d0b4) into master (aba2b74) will decrease coverage by 2.85%.
The diff coverage is 100.00%.

❗ Current head db2d0b4 differs from pull request most recent head 644e5be. Consider uploading reports for the commit 644e5be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   85.85%   83.00%   -2.85%     
==========================================
  Files          14       14              
  Lines         813      818       +5     
==========================================
- Hits          698      679      -19     
- Misses        115      139      +24     
Files Coverage Δ
scrapy_poet/page_input_providers.py 93.33% <100.00%> (-6.67%) ⬇️

... and 3 files with indirect coverage changes

scrapy_poet/page_input_providers.py Outdated Show resolved Hide resolved
@Gallaecio Gallaecio closed this Nov 21, 2023
@Gallaecio Gallaecio reopened this Nov 21, 2023
@kmike kmike merged commit 74ab3a8 into scrapinghub:master Nov 21, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants