Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update to support Python3.13 #146

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

ishanasse
Copy link
Contributor

@ishanasse ishanasse commented Dec 31, 2024

Description

Please include a summary of the change and, if applicable, which issue this change is associated with. Please also
include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project (no GitHub actions compalints! run make lint before
    committing!)
  • I have commented my code, pydocstyle and darglint are happy, docstrings are in google docstring format, and all
    docstrings include a summary, args, returns and raises fields (even if N/A)
  • I have added tests that prove my fix is effective or that my feature works, if adding "functional" tests please
    note if there are any considerations for the vrnetlab setup
  • New and existing unit tests pass locally with my changes

@carlmontanari
Copy link
Contributor

lgtm! ignore the build fail. ill deal w/ that tomorrow or.... eventually :P

@carlmontanari carlmontanari merged commit ffe37ac into scrapli:main Dec 31, 2024
9 of 12 checks passed
@ishanasse
Copy link
Contributor Author

ishanasse commented Jan 6, 2025

@carlmontanari Thank you for reviewing and merging my PR.
I was wondering if there are any plans for a release that will include this change. Please let me know if there's anything I can do to help with the process.

@carlmontanari
Copy link
Contributor

release will happen end of the month sticking w/ the calendar release cycle that scrapli has been on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants