Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: add serp #242

Merged
merged 1 commit into from
Jan 20, 2025
Merged

provider: add serp #242

merged 1 commit into from
Jan 20, 2025

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Jan 16, 2025

Subset of #218 that is a first step towards allowing the serp spider from https://github.com/zytedata/zyte-spider-templates to use Serp page objects.

@Gallaecio Gallaecio requested review from wRAR and kmike and removed request for wRAR January 16, 2025 16:16
@Gallaecio Gallaecio marked this pull request as ready for review January 16, 2025 16:16
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (bf58d54) to head (4aa88b4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          14       14           
  Lines        1647     1647           
  Branches      301      301           
=======================================
  Hits         1610     1610           
  Misses         17       17           
  Partials       20       20           
Files with missing lines Coverage Δ
scrapy_zyte_api/providers.py 94.73% <ø> (ø)

@wRAR
Copy link
Contributor

wRAR commented Jan 17, 2025

We need to add the same thing 5 places, I wonder if it can be made more error-prone :)

@kmike kmike merged commit a52ab36 into scrapy-plugins:main Jan 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants