Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SessionConfig.process_request #246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Jan 29, 2025

Resolves #244.

See the docstring of the new method for details.

PS: I have thought about adding a way to also run code when a session is removed, for clean-up purposes, but maybe we can add that later on.

@Gallaecio Gallaecio requested review from kmike and wRAR January 29, 2025 15:49
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (a52ab36) to head (ee41201).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +0.01%     
==========================================
  Files          14       14              
  Lines        1647     1656       +9     
  Branches      301      301              
==========================================
+ Hits         1610     1619       +9     
  Misses         17       17              
  Partials       20       20              
Files with missing lines Coverage Δ
scrapy_zyte_api/__init__.py 100.00% <ø> (ø)
scrapy_zyte_api/_session.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sessions are not created in advance if BaseProductPage is used.
2 participants