Fix compatibility with ZAPI proxy mode in response handling #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no exact equivalence of `X-Crawlera-Version` in ZAPI. The `Zyte-Request-Id` header seems to be the closest match yet it does not cover certain types of errors like authentication errors (e.g. `curl -v https://example.com/ -x $API_URL`). Thus `zyte-error-type` is introduced as well to also cover such scenarios.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 295 295
=========================================
Hits 295 295 ☔ View full report in Codecov by Sentry. |
Gallaecio
reviewed
Feb 2, 2024
Gallaecio
reviewed
Feb 2, 2024
Gallaecio
reviewed
Feb 2, 2024
| @@ -93,25 +90,34 @@ def _assert_enabled(self, spider, | |||
| crawler = self._mock_crawler(spider, settings) | |||
| mw = self.mwcls.from_crawler(crawler) | |||
| mw.open_spider(spider) | |||
| httpproxy = HttpProxyMiddleware.from_crawler(crawler) | |||
There was a problem hiding this comment.
Most test changes are to apply this, i.e. run the Scrapy middleware not just the proxy middleware. They are not specifically needed for this change in the latest iteration, but I think it is best to keep the changes. They e.g. pointed to some bad proxy URLs (missing : after the API key).
wRAR
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no exact equivalence of
X-Crawlera-Versionin ZAPI. TheZyte-Request-Idheader seems to be the closest match yet it does not cover certain types of errors like authentication errors (e.g.curl -v https://example.com/ -x $API_URL).Thus
zyte-error-typeis introduced as well to also cover such scenarios.