Skip to content

Commit

Permalink
fix(1079): Remove unnecessary autoDeployKeyGenerationEnabled function (
Browse files Browse the repository at this point in the history
…#168)

* feat(scm-github): Add key pair generation method and push pub key to scm

* feat(scm-github): Add key pair generation method and push pub key to scm

* feat(): add accessor function for checking autoDeployKeyGeneration

* feat(scm-github): add tests for addDeployKey and checkAutoDeployKeyGeneration

* refactor(): change function names and localize constants

* refactor(): use object destructing in config and use maps
  • Loading branch information
supra08 authored Aug 5, 2020
1 parent 503dbd1 commit c1e4cfb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
9 changes: 0 additions & 9 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -372,15 +372,6 @@ class GithubScm extends Scm {
}
}

/**
* Returns whether auto deploy key generation is enabled or not
* @async _autoDeployKeyGenerationEnabled
* @return {Boolean} Resolves to the private key string
*/
async _autoDeployKeyGenerationEnabled() {
return this.config.autoDeployKeyGeneration;
}

/**
* Look up a webhook from a repo
* @async _findWebhook
Expand Down
8 changes: 0 additions & 8 deletions test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1954,14 +1954,6 @@ jobs:
});
});

describe('autoDeployKeyGenerationEnabled', () => {
it('returns a boolean check', () =>
scm.autoDeployKeyGenerationEnabled().then((check) => {
assert.isBoolean(check);
})
);
});

describe('getBellConfiguration', () => {
it('returns a default configuration', () => (
scm.getBellConfiguration().then((config) => {
Expand Down

0 comments on commit c1e4cfb

Please sign in to comment.