-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
10 changed files
with
225 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
--- | ||
type: docs | ||
--- | ||
|
||
# Objective | ||
|
||
Enhance path editing features. | ||
|
||
## Related Links | ||
|
||
- Branches: Artbox, [feature-snap-to-path-distance](https://gitlab.gnome.org/pixelmixer/artbox/-/tree/feature-snap-to-path-distance?ref_type=heads), [feature-path-editing](https://gitlab.gnome.org/pixelmixer/artbox/-/tree/feature-path-editing?ref_type=heads) | ||
|
||
## Design Revisions | ||
|
||
| **Revision** | **Current Design** | **Issues** | **Changes** | | ||
|---------------|---------------------|-------------|-------------| | ||
| **1. Path Snap Distance** | Snapping uses a single distance for snapping to grid, guides, and paths. | Users can't adjust snapping precision separately for paths. | Introduced an independent `Active Paths` preference option. | | ||
| **2. Path Visibility Control** | Created don't automatically show visibility. | Users need to manually enable visibility for newly created paths. | Added visibility control for paths at creation via a new `Visible` property. | | ||
|
||
## MR Description | ||
|
||
This merge request improves the snapping and visibility options for paths, allowing users finer control over snap distances for paths and automatic visibility for new paths. | ||
|
||
### Changes | ||
|
||
1. **Path Snap Distance**: | ||
- Extended the `gimp_image_snap_point` function in `gimpimage-snap.c` to accept new `epsilon_path_x` and `epsilon_path_y` parameters, which allow different snapping tolerances for paths compared to grid or guide snapping. | ||
- Updated `gimp_display_shell_snap_coords` to include the `snap_path_distance` property, adding flexibility to set path-specific snap distance through `snap_path_distance` configured in the display. | ||
|
||
2. **Path Visibility Control**: | ||
- Introduced a new `visible` property in `GimpToolPathPrivate`, allowing paths to be visible upon creation. This property ensures new paths are visible by default unless otherwise configured. | ||
- Added `PROP_VISIBLE` to `gimp_tool_path_class_init` in `gimp_tool_path.c` to manage path visibility and bind it to the vector tool settings. | ||
- In `gimp_vector_options`, added a new checkbox in the GUI labeled "Visible Path" to control path visibility in the tool options. | ||
|
||
### Benefit | ||
|
||
- **Improved Snap Control**: Users can now adjust snap distances independently for paths, providing more precise control based on the type of element (e.g., paths versus grids). | ||
- **Enhanced Workflow with Auto-Visibility**: Automatically making paths visible at creation enhances user feedback and reduces manual toggling, streamlining the editing process. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.