docs: add ScrollBadgeEligibilityCheck to ScrollBadgePermissionless (#41)

* docs: add ScrollBadgeEligibilityCheck to ScrollBadgePermissionless example * remove function
scroll-tech · Apr 29, 2024 · 61f5724 · 61f5724
1 parent 6361dd0
commit 61f5724
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/src/badge/examples/ScrollBadgePermissionless.sol b/src/badge/examples/ScrollBadgePermissionless.sol
@@ -6,11 +6,12 @@ import {Attestation} from "@eas/contracts/IEAS.sol";
 
 import {ScrollBadge} from "../ScrollBadge.sol";
 import {ScrollBadgeSelfAttest} from "../extensions/ScrollBadgeSelfAttest.sol";
+import {ScrollBadgeEligibilityCheck} from "../extensions/ScrollBadgeEligibilityCheck.sol";
 import {ScrollBadgeSingleton} from "../extensions/ScrollBadgeSingleton.sol";
 
 /// @title ScrollBadgePermissionless
 /// @notice A simple badge that anyone can mint in a permissionless manner.
-contract ScrollBadgePermissionless is ScrollBadgeSelfAttest, ScrollBadgeSingleton {
+contract ScrollBadgePermissionless is ScrollBadgeSelfAttest, ScrollBadgeEligibilityCheck, ScrollBadgeSingleton {
     constructor(address resolver_) ScrollBadge(resolver_) {
         // empty
     }
@@ -19,7 +20,7 @@ contract ScrollBadgePermissionless is ScrollBadgeSelfAttest, ScrollBadgeSingleto
     function onIssueBadge(Attestation calldata attestation)
         internal
         virtual
-        override (ScrollBadgeSelfAttest, ScrollBadgeSingleton)
+        override (ScrollBadge, ScrollBadgeSelfAttest, ScrollBadgeSingleton)
         returns (bool)
     {
         return super.onIssueBadge(attestation);
@@ -29,7 +30,7 @@ contract ScrollBadgePermissionless is ScrollBadgeSelfAttest, ScrollBadgeSingleto
     function onRevokeBadge(Attestation calldata attestation)
         internal
         virtual
-        override (ScrollBadgeSelfAttest, ScrollBadgeSingleton)
+        override (ScrollBadge, ScrollBadgeSelfAttest, ScrollBadgeSingleton)
         returns (bool)
     {
         return super.onRevokeBadge(attestation);

diff --git a/src/badge/examples/ScrollBadgeWhale.sol b/src/badge/examples/ScrollBadgeWhale.sol
@@ -11,17 +11,13 @@ import {Unauthorized} from "../../Errors.sol";
 
 /// @title ScrollBadgeWhale
 /// @notice A badge that shows that the user had 1000 ETH or more at the time of minting.
-contract ScrollBadgeWhale is ScrollBadgePermissionless, ScrollBadgeEligibilityCheck {
+contract ScrollBadgeWhale is ScrollBadgePermissionless {
     constructor(address resolver_) ScrollBadgePermissionless(resolver_) {
         // empty
     }
 
     /// @inheritdoc ScrollBadge
-    function onIssueBadge(Attestation calldata attestation)
-        internal
-        override (ScrollBadge, ScrollBadgePermissionless)
-        returns (bool)
-    {
+    function onIssueBadge(Attestation calldata attestation) internal override returns (bool) {
         if (!super.onIssueBadge(attestation)) {
             return false;
         }
@@ -34,11 +30,7 @@ contract ScrollBadgeWhale is ScrollBadgePermissionless, ScrollBadgeEligibilityCh
     }
 
     /// @inheritdoc ScrollBadge
-    function onRevokeBadge(Attestation calldata attestation)
-        internal
-        override (ScrollBadge, ScrollBadgePermissionless)
-        returns (bool)
-    {
+    function onRevokeBadge(Attestation calldata attestation) internal override returns (bool) {
         if (!super.onRevokeBadge(attestation)) {
             return false;
         }