Skip to content

Commit

Permalink
fix: fix incorrect JSON encoding in ScrollBadgePowerRank example (#47)
Browse files Browse the repository at this point in the history
* fix: fix incorrect JSON encoding in ScrollBadgePowerRank example

* use encodePacked for token name
  • Loading branch information
Thegaram authored Jul 2, 2024
1 parent a68c8ab commit bf63c29
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/badge/examples/ScrollBadgePowerRank.sol
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ contract ScrollBadgePowerRank is
/// @inheritdoc ScrollBadge
function badgeTokenURI(bytes32 uid) public view override returns (string memory) {
uint256 rank = badgeRank[uid];
string memory name = string(abi.encode("Scroll Power Rank #", Strings.toString(rank)));
string memory name = string(abi.encodePacked("Scroll Power Rank #", Strings.toString(rank)));
string memory description = "Scroll Power Rank Badge";
string memory image = ""; // IPFS, HTTP, or data URL
string memory tokenUriJson = Base64.encode(
abi.encodePacked('{"name":"', name, '", "description":"', description, ', "image": "', image, '"}')
abi.encodePacked('{"name":"', name, '", "description":"', description, '", "image": "', image, '"}')
);
return string(abi.encodePacked("data:application/json;base64,", tokenUriJson));
}
Expand Down

0 comments on commit bf63c29

Please sign in to comment.