Merged
Conversation
CodSpeed Performance ReportMerging #434 will not alter performanceComparing Summary
|
yiweichi
approved these changes
Nov 24, 2025
frisitano
added a commit
that referenced
this pull request
Nov 24, 2025
This reverts commit 81c904c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the consolidation logic such that we always update the fork choice state if the block number is greater than the finalized block number. This allows us to account for the case in which a reorg has occurred and the new batch is different from the old. In the model on the
mainbranch, we would be eventually consistent whenattributes.number > fcs.safe_blcock_info().numberbut the model in this PR reduces latency to arrive at the correct state.