Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the v7 blob decoding logic to pass the version byte through to the payload decoder and use it when constructing the Batch object, rather than hardcoding version 7. This allows the decoder to correctly handle v8/v9/v10 blobs using the same decoding logic. A new test verifies that v8 blobs can be decoded with the correct version preserved.
- Modified
decode_v7_payloadto accept a version parameter - Updated
Batch::newcall to use the dynamic version instead of hardcoded 7 - Added test case to verify v8 blob decoding
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Could you fix the lint by running: |
CodSpeed Performance ReportMerging #456 will not alter performanceComparing Summary
|
Member
|
Closed by this #459 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.