-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable Darwin for deterministic deployment #25
feat: enable Darwin for deterministic deployment #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiweichi Something's wrong with the tests, it seems they're run on the wrong branch (fails on src/test/alternative-gas-token/AlternativeGasTokenTestBase.t.sol
, which is not part of this PR).
seems related to I delete some used function in |
…nto feat-enable-darwin-for-scroll-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The first commits are just merging Xi's recent changes. I recommend only reviewing from commit ebffab7.