Update Solhint Configuration #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Solhint configuration file to enhance linting rules for better code quality and enforce stricter visibility constraints. The changes include modifying the func-visibility rule to an error level and setting ignoreConstructors to false, ensuring that constructors adhere to visibility constraints. Additionally, a maximum line length of 120 characters has been established to improve code readability. The configuration now includes a warning for unused variables to promote cleaner code and disallows the use of with to prevent confusion. Empty blocks are no longer permitted, ensuring that all logic is complete. The constructor-super rule is now enforced, requiring super calls in constructors when inheriting from another contract. Furthermore, a warning has been added against relying on block timestamps, and each import statement is enforced to import only one file to enhance modularity. Inline assembly is disallowed to mitigate potential security risks, and naming conventions for variables have been reinforced while ignoring destructuring. Finally, the use of revert() for error handling is required. Overall, this update aims to improve code quality and maintainability within the project by encouraging adherence to best practices and facilitating early detection of potential issues.