Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[don't-merge] test vk deserialization #162

Closed
wants to merge 4 commits into from
Closed

[don't-merge] test vk deserialization #162

wants to merge 4 commits into from

Conversation

silathdiir
Copy link
Contributor

This code tests vk serialization and deserialization with the hack fix scroll-tech/halo2#52.

vk1 = pk.get_vk();
raw_vk2 = serialize(vk1);
vk2 = read_vk(raw_vk2);

Log and compare vk1 and vk2, then use vk2 for further verification.

@silathdiir silathdiir requested a review from lispc July 11, 2023 00:04
@silathdiir silathdiir marked this pull request as draft July 11, 2023 06:11
@silathdiir
Copy link
Contributor Author

Merge into #160

@silathdiir silathdiir closed this Jul 11, 2023
@silathdiir silathdiir deleted the test-deserialize-vk branch July 11, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc Awaiting requested review from lispc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silathdiir