Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run circuit-capacity-checker for each chunk in mock-testnet #269

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Sep 12, 2023

Summary

  • move common functions (prepare-ccc and run-ccc) of test-circuit-capacity-checker to test-utils.

  • use above common functions in both integration-test and mock-testnet.


let avg_ccc_time = start_time.elapsed().as_millis() as usize / tx_num;
log::info!("avg time each tx: {avg_ccc_time}ms",);
assert!(avg_ccc_time < 100);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lispc could I also assert this time when runs in mock-testnet?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix to only assert < 100ms in test (not mock-testnet) in commit abc5300.

@lispc lispc merged commit 30ffc3f into main Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants