Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use viper #1505

Merged
merged 3 commits into from
Aug 27, 2024
Merged

feat: use viper #1505

merged 3 commits into from
Aug 27, 2024

Conversation

colinlyguo
Copy link
Member

based on this fix pr: #1502

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.62651% with 36 lines in your changes missing coverage. Please review.

Project coverage is 51.51%. Comparing base (67c8392) to head (b6570a0).

Files Patch % Lines
rollup/internal/controller/relayer/l2_relayer.go 47.22% 14 Missing and 5 partials ⚠️
rollup/internal/config/config.go 68.29% 8 Missing and 5 partials ⚠️
rollup/internal/controller/relayer/l1_relayer.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           fix-override-config-private-key    #1505      +/-   ##
===================================================================
- Coverage                            51.60%   51.51%   -0.10%     
===================================================================
  Files                                  156      155       -1     
  Lines                                12789    12797       +8     
===================================================================
- Hits                                  6600     6592       -8     
- Misses                                5621     5632      +11     
- Partials                               568      573       +5     
Flag Coverage Δ
rollup 55.37% <56.62%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yiweichi
Copy link
Member

hey @colinlyguo, tested and works well. should we merge it?

@colinlyguo
Copy link
Member Author

colinlyguo commented Aug 27, 2024

hey @colinlyguo, tested and works well. should we merge it?

sounds good. pls ping other reviewers to pass in your PR.

@colinlyguo colinlyguo merged commit 7c6d46a into fix-override-config-private-key Aug 27, 2024
4 checks passed
@colinlyguo colinlyguo deleted the feat-use-viper branch August 27, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants