forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 382
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rewrite geth_utils with go.work (#875)
* Remove assembly in geth-utils (privacy-scaling-explorations#1553) Remove geth-utils and examples. New feature (non-breaking change which adds functionality) - Assembly was introduced in #91 to build examples to use geth-util. It was not used elsewhere in the codebase. - The examples are removed as we currently don't use geth-util like the way the examples show. (Note that the examples also fail to run now. The transactions in the examples would fail because the trace config defaults to a 0 block gas limit. It runs after adding a block gas limit.) - I found those examples unused when reviewing how we use the tracing API. It is much easier to review the tracing code after removing the Assembly. - The Readme mentioned a TODO CLI, which we never built. I think it might be interesting to create a good first issue for people to extend testool(https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/690b2f143a94b7474f0c99493a99b0f2c53d93b8/testool/README.md#L38) for it. * rewrite geth_utils with go.work * fix make doc --------- Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
- Loading branch information
1 parent
13aaee3
commit 47236ff
Showing
18 changed files
with
215 additions
and
920 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.