fix: prevent request badge showing when no related media #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overseerr
|
||||||||||||||||||||||||||||
| Project |
overseerr
|
| Branch Review |
refs/pull/4100/merge
|
| Run status |
|
| Run duration | 02m 25s |
| Commit |
|
| Committer | Brandon Cohen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
28
|
| View all changes introduced in this branch ↗︎ | |
sct
approved these changes
Apr 7, 2025
1 task
engels74
pushed a commit
to engels74/overseerr-anime-source
that referenced
this pull request
Apr 16, 2025
engels74
pushed a commit
to engels74/overseerr-anime-source
that referenced
this pull request
Apr 16, 2025
engels74
pushed a commit
to engels74/overseerr-anime-source
that referenced
this pull request
Apr 16, 2025
engels74
pushed a commit
to engels74/overseerr-anime-source
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an underlying issue where some requests can lose their associated media relation. When this happens, the request would no longer appear in the requests list, but the badge count would still reflect it—leading to a mismatch between the count and the requests list.
This PR updates the logic so that only requests with a valid media relation (i.e., those that would actually appear in the requests list) are included in the badge count.
Screenshot (if UI-related)
N/A
To-Dos
yarn build