Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCTPDBG statement for connections closing. #707

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JonathanLennox
Copy link
Contributor

This reuses the existing sctp_log_closing mechanism.

@JonathanLennox
Copy link
Contributor Author

I picked an unused SCTP_DEBUG constant for this; if there's a better value I should use please let me know.

This reuses the existing sctp_log_closing mechanism.
@@ -340,6 +340,10 @@ void rto_logging(struct sctp_nets *net, int from);

void sctp_log_closing(struct sctp_inpcb *inp, struct sctp_tcb *stcb, int16_t loc);

#ifdef SCTP_DEBUG
#define SCTP_LOG_CLOSING 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCTP_LOG_CLOSING should be defined via the build system. Since you use it for debugging, maybe something like
env CFLAGS=-DSCTP_LOG_CLOSING ./configure
is good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to put the new log statement in a single place, and the existing sctp_log_closing function was only called if the SCTP_LOG_CLOSING define is set.

Currently (prior to my patch), sctp_log_closing only does something if SCTP_LOCAL_TRACE_BUF is set.

With my latest commit, the behavior (other than the addition of the new debug message) should be the same as it was previously for all compiler flags.

Instead, conditionalize its call to SCTP_CTR6 on SCTP_LOG_CLOSING.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants