Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Broadcast class and update comments in Zulu #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scubaninja
Copy link
Owner

@scubaninja scubaninja commented Nov 14, 2024

This pull request involves significant changes to the Broadcast class in the server/Models directory, including the addition of new properties and methods, as well as the translation of comments into Zulu. Additionally, a similar Broadcast class was added to the server/Models/tests.cs file.

Key Changes:

Updates to Broadcast class in server/Models/Broadcast.cs:

  • Added several new properties to the Broadcast class, including EmailId, Status, ReplyTo, and CreatedAt. These properties include default values where appropriate.
  • Translated existing comments into Zulu, providing descriptions for the new properties and methods.
  • Removed the FromMarkdownEmail and FromMarkdown methods, which created Broadcast instances from markdown documents.
  • Removed the ContactCount method, which calculated the number of contacts based on the SendToTag.

Addition of Broadcast class in server/Models/tests.cs:

  • Added a new Broadcast class with the same properties and Zulu comments as the updated Broadcast class in Broadcast.cs.

@scubaninja scubaninja self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant