perf: run umap in parallel when rng=None is passed#4036
Open
flying-sheep wants to merge 3 commits intomainfrom
Open
perf: run umap in parallel when rng=None is passed#4036flying-sheep wants to merge 3 commits intomainfrom
rng=None is passed#4036flying-sheep wants to merge 3 commits intomainfrom
Conversation
rng=None is passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4036 +/- ##
==========================================
- Coverage 78.51% 78.50% -0.01%
==========================================
Files 117 117
Lines 12753 12750 -3
==========================================
- Hits 10013 10010 -3
Misses 2740 2740
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Benchmark changes
Comparison: https://github.com/scverse/scanpy/compare/9bc2c1ed1bd1cf6f6c06cec71cce99916d048163..f51185ef4c38bd72b9f6e6647c4d74515507dfb8 More details: https://github.com/scverse/scanpy/pull/4036/checks?check_run_id=70245416359 |
ilan-gold
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
milestone 1.13.0, since 1.12.x doesn’t have
rng.scanpy 2.0 will have
rng=Noneby default and therefore the speedup.