Skip to content

Conversation

@marcovarrone
Copy link
Contributor

Description

  • Change flavor option in calculate_niche to cellcharter_simple` for CellCharter
  • Default distance = 3 for cellcharter_simple.

How has this been tested?

pytest runs successfully.
However, I see there are no unit tests for calculate_niche with cellcharter (now cellcharter_simple).

Closes

Closes #977

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.24%. Comparing base (d8b8f91) to head (98a3a78).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/squidpy/gr/_niche.py 0.00% 18 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d8b8f91) and HEAD (98a3a78). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d8b8f91) HEAD (98a3a78)
4 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #978       +/-   ##
===========================================
- Coverage   66.63%   24.24%   -42.40%     
===========================================
  Files          40       41        +1     
  Lines        6060     6072       +12     
  Branches     1015     1018        +3     
===========================================
- Hits         4038     1472     -2566     
- Misses       1662     4583     +2921     
+ Partials      360       17      -343     
Files with missing lines Coverage Δ
src/squidpy/gr/_niche.py 11.76% <0.00%> (-23.10%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis
Copy link
Member

Hey @marcovarrone, sorry for having let this gone stale. I'm not the biggest fan of changing the name but very much see your point - I've added the use_rep parameter and a warning in case the user now goes with the PCA approach - would this work for you?

@marcovarrone
Copy link
Contributor Author

Hi @timtreis, no worries! Looks great to me

@timtreis timtreis merged commit a3061c2 into scverse:main Oct 26, 2025
10 checks passed
selmanozleyen pushed a commit to selmanozleyen/squidpy that referenced this pull request Nov 3, 2025
…cverse#978)

* Change niche flavor to cellcharter_simple and default distance = 3

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added warning message

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tim Treis <tim.treis@helmholtz-munich.de>
Co-authored-by: Tim Treis <tim.treis@stud.uni-heidelberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change CellCharter name and default values

3 participants