fix(backup): use keyspace ownership/locality information returned by …

…Scylla

Validated manually as we don't have a single node test setup.

Fixes #3989

pkg/scyllaclient/model.go

@@ -178,9 +178,11 @@ const (
 type Ring struct {
 	ReplicaTokens []ReplicaTokenRanges
 	HostDC        map[string]string
-	Replication   ReplicationStrategy
-	RF            int
-	DCrf          map[string]int // initialized only for NetworkTopologyStrategy
+	// Replication is not returned by Scylla, but assumed by SM.
+	// Don't use it for correctness.
+	Replication ReplicationStrategy
+	RF          int
+	DCrf        map[string]int // initialized only for NetworkTopologyStrategy
 }
 
 // Datacenters returns a list of datacenters the keyspace is replicated in.

pkg/service/backup/model.go

@@ -491,10 +491,18 @@ func (f dcFilter) filter(_, _ string, ring scyllaclient.Ring) bool {
 }
 
 // Filters out tables containing local data, as they shouldn't be restored.
-type localDataFilter struct{}
+type localDataFilter struct {
+	keyspaces map[scyllaclient.KeyspaceType][]string
+}
 
-func (f localDataFilter) filter(_, _ string, ring scyllaclient.Ring) bool {
-	return ring.Replication != scyllaclient.LocalStrategy
+func (f localDataFilter) filter(ks, _ string, _ scyllaclient.Ring) bool {
+	user, okU := f.keyspaces[scyllaclient.KeyspaceTypeUser]
+	nonLocal, okNL := f.keyspaces[scyllaclient.KeyspaceTypeNonLocal]
+	if !okU || !okNL {
+		panic(fmt.Sprintf("keyspace map %v does not contain expected entries %s and %s",
+			f.keyspaces, scyllaclient.KeyspaceTypeUser, scyllaclient.KeyspaceTypeNonLocal))
+	}
+	return slices.Contains(user, ks) || slices.Contains(nonLocal, ks)
 }
 
 // Filters out views as they are restored by re-creating them on restored base table.

pkg/service/backup/service.go

@@ -161,10 +161,15 @@ func (s *Service) targetFromProperties(ctx context.Context, clusterID uuid.UUID,
 		return Target{}, err
 	}
 
+	ks, err := client.KeyspacesByType(ctx)
+	if err != nil {
+		return Target{}, errors.Wrap(err, "get keyspaces by type")
+	}
+
 	filters := []tabFilter{
 		patternFilter{pattern: f},
 		dcFilter{dcs: strset.New(dcs...)},
-		localDataFilter{},
+		localDataFilter{keyspaces: ks},
 	}
 
 	// Try to add view filter - possible only when credentials are set