Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
After removing the "MODULE" parameter from find_package(Boost) in af9b804, the build started using Boost's native package config instead of cmake-boost. This caused seastar.pc to contain target references (e.g. Boost::program_options) rather than actual library paths, breaking builds of projects consuming seastar via pkg-config: ``` /usr/bin/clang++ ... \ Boost::program_options Boost::thread /usr/lib64/libcares.so /usr/lib64/libfmt.so.11.0.2 -L/usr/lib64 -llz4 -Xlinker --dependency-file -Xlinker CMakeFiles/scylla.dir/Debug/link.d CMakeFiles/scylla_version.dir/Debug/release.cc.o CMakeFiles/scylla.dir/Debug/main.cc.o \ ... clang++: error: no such file or directory: 'Boost::program_options' clang++: error: no such file or directory: 'Boost::thread' ``` In this change, use generator expressions to obtain the actual library paths for pkg-config files, ensuring correct linking for downstream projects. This should address the regression introduced by af9b804. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
- Loading branch information