Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: add moving push to json_list #2589

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

travisdowns
Copy link
Contributor

When building up json lists in memory we have only the push method which takes const T&, but one taking an rvalue reference and moves into the list would be useful for heavy elements.

When building up json lists in memory we have only the `push` method
which takes const T&, but one taking an rvalue reference and moves
into the list would be useful for heavy elements.
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avikivity avikivity merged commit 613d8b3 into scylladb:master Dec 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants