[DO-NOT-REVIEW] http: generalize reply's Content-Type setting #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For setting a content type on a reply in the HTTP server, we had two different methods - one set_mime_type() which accepted only full MIME types (e.g., "text/html"), and one set_content_type() which took a file extension (e.g, "html") and looked it up in a short map we had, like a tiny version of /etc/mime.types. But some reply methods like write_body() and done() only called set_content_type() meaning they could only set content types from that short list of known types - and not any general MIME type. This forced Seastar users to jump through hoops to use additional mime types - for example to call write_body() on a wrong type and then call set_mime_type() to override it, or patch the extension map to add more and more types to it. This patch fixes this problem for good: With this patch, we no longer have two different reply methods - there is just one, set_content_type(). The name set_mime_type() remains a deprecated alias. The merged set_content_type() can recognize *either* a full-fledged MIME type like "text/html", or if there is no slash in the name - it is looked up in the list of extensions (e.g., "html"). While doing this, I also changed the set_content_type() from taking a "const sstring&" like in the old days, to the more modern std::string_view. I believe this will not cause problems for applications, as a const sstring& can be implicitly converted into an std::string_view so old code should continue to compile. Fixes scylladb#964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for testing the change on top of #2729