Updated abstractions ref & static analysis fixes.

sdcondon · May 6, 2024 · 518688c · 518688c
1 parent fb63de1
commit 518688c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/src/FlUnit.Documentation/wwwroot/md/roadmap.md b/src/FlUnit.Documentation/wwwroot/md/roadmap.md
@@ -2,9 +2,9 @@
 
 Proper issue tracking and a formal plan would be overkill, so the "roadmap" consists of just a bullet list to organise my thoughts:
 
-Next up:
+At the moment:
 
-- Fix VSTest adapter so that the test assembly is loaded in a MetadataLoadContext when discovering tests.
+- *Nothing at the moment - working on other projects*.
 
 On the to-do list for soon-ish:
 

diff --git a/src/FlUnit/FlUnit.csproj b/src/FlUnit/FlUnit.csproj
@@ -65,7 +65,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="FlUnit.Abstractions" Version="4.0.0" />
+    <PackageReference Include="FlUnit.Abstractions" Version="5.0.0" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

diff --git a/src/FlUnit/FunctionTest.cs b/src/FlUnit/FunctionTest.cs
@@ -157,7 +157,7 @@ public async ValueTask AssertAsync()
                 {
                     await assert(testCase.invocationOutcome);
                 }
-                catch (Exception e) when (!(e is ITestFailureDetails))
+                catch (Exception e) when (e is not ITestFailureDetails)
                 {
                     throw new TestFailureException(e.Message, e.StackTrace, e);
                 }
@@ -344,7 +344,7 @@ public async ValueTask AssertAsync()
                 {
                     await assert(testCase.prereqs, testCase.invocationOutcome);
                 }
-                catch (Exception e) when (!(e is ITestFailureDetails))
+                catch (Exception e) when (e is not ITestFailureDetails)
                 {
                     throw new TestFailureException(e.Message, e.StackTrace, e);
                 }
@@ -488,7 +488,7 @@ public async ValueTask ActAsync()
             // i for "test case #", and (when there are multiple prereqs) an integer for the prequisite of that index.
             public string ToString(string format, IFormatProvider formatProvider)
             {
-                List<string> nonTypeNames = new List<string>();
+                List<string> nonTypeNames = new();
 
                 var tuple = prereqs as ITuple;
                 for (var i = 0; i < tuple.Length; i++)
@@ -553,7 +553,7 @@ public async ValueTask AssertAsync()
                 {
                     await assert(testCase.prereqs.Item1, testCase.prereqs.Item2, testCase.invocationOutcome);
                 }
-                catch (Exception e) when (!(e is ITestFailureDetails))
+                catch (Exception e) when (e is not ITestFailureDetails)
                 {
                     throw new TestFailureException(e.Message, e.StackTrace, e);
                 }
@@ -700,7 +700,7 @@ public async ValueTask ActAsync()
             // i for "test case #", and (when there are multiple prereqs) an integer for the prequisite of that index.
             public string ToString(string format, IFormatProvider formatProvider)
             {
-                List<string> nonTypeNames = new List<string>();
+                List<string> nonTypeNames = new();
 
                 var tuple = prereqs as ITuple;
                 for (var i = 0; i < tuple.Length; i++)
@@ -765,7 +765,7 @@ public async ValueTask AssertAsync()
                 {
                     await assert(testCase.prereqs.Item1, testCase.prereqs.Item2, testCase.prereqs.Item3, testCase.invocationOutcome);
                 }
-                catch (Exception e) when (!(e is ITestFailureDetails))
+                catch (Exception e) when (e is not ITestFailureDetails)
                 {
                     throw new TestFailureException(e.Message, e.StackTrace, e);
                 }
@@ -915,7 +915,7 @@ public async ValueTask ActAsync()
             // i for "test case #", and (when there are multiple prereqs) an integer for the prequisite of that index.
             public string ToString(string format, IFormatProvider formatProvider)
             {
-                List<string> nonTypeNames = new List<string>();
+                List<string> nonTypeNames = new();
 
                 var tuple = prereqs as ITuple;
                 for (var i = 0; i < tuple.Length; i++)
@@ -980,7 +980,7 @@ public async ValueTask AssertAsync()
                 {
                     await assert(testCase.prereqs.Item1, testCase.prereqs.Item2, testCase.prereqs.Item3, testCase.prereqs.Item4, testCase.invocationOutcome);
                 }
-                catch (Exception e) when (!(e is ITestFailureDetails))
+                catch (Exception e) when (e is not ITestFailureDetails)
                 {
                     throw new TestFailureException(e.Message, e.StackTrace, e);
                 }
@@ -1133,7 +1133,7 @@ public async ValueTask ActAsync()
             // i for "test case #", and (when there are multiple prereqs) an integer for the prequisite of that index.
             public string ToString(string format, IFormatProvider formatProvider)
             {
-                List<string> nonTypeNames = new List<string>();
+                List<string> nonTypeNames = new();
 
                 var tuple = prereqs as ITuple;
                 for (var i = 0; i < tuple.Length; i++)
@@ -1198,7 +1198,7 @@ public async ValueTask AssertAsync()
                 {
                     await assert(testCase.prereqs.Item1, testCase.prereqs.Item2, testCase.prereqs.Item3, testCase.prereqs.Item4, testCase.prereqs.Item5, testCase.invocationOutcome);
                 }
-                catch (Exception e) when (!(e is ITestFailureDetails))
+                catch (Exception e) when (e is not ITestFailureDetails)
                 {
                     throw new TestFailureException(e.Message, e.StackTrace, e);
                 }