Hmm, could have sworn I made GraphPlan internal - 'cos its not fully …

…implemented yet. Ah well. Fixed.

Also some docs and comments.

src/SCClassicalPlanning.Alternatives/Planning/Utilities/ProblemInspector_MergedUnmatchLogic.cs

@@ -5,7 +5,7 @@
 namespace SCClassicalPlanning.Alternatives.Planning.Utilities
 {
     /// <summary>
-    /// Just includes a version of ProblemInspector.GetRelevantActionSchemas that attempts to be more efficient,
+    /// Just includes a version of ProblemInspector.GetRelevantSchemaSubstitutions that attempts to be more efficient,
     /// but unfortunately doesn't quite do the job. Worth keeping around for pondering, though.
     /// </summary>
     public static class ProblemInspector_MergedUnmatchLogic

src/SCClassicalPlanning.Tests/Planning/Utilities/ProblemInspectorTests.cs

@@ -67,7 +67,7 @@ private record GetRelevantActionsTestCase(Problem Problem, Goal Goal, Action[] E
                         Add(element1),
                         Remove(element2),
                         Swap(element2, element1),
-                        Swap(element2, element1), // TODO-BUG: yeah, hits twice - for the element1 presence and for the element2 non-presence)
+                        Swap(element2, element1), // TODO-BUG: yeah, hits twice - for the element1 presence and for the element2 non-presence). dedupe should probably be expected.
                     }),
 
                 new(

src/SCClassicalPlanning/Effect.cs

@@ -51,8 +51,10 @@ public Effect(Sentence sentence) : this(ConstructionVisitor.Visit(sentence)) { }
         /// <summary>
         /// Gets the set of literals that comprise this effect.
         /// </summary>
-        // TODO-PERFORMANCE: Should perhaps store add and delete lists separately, for performance. Application and Regression are going to be far more common than wanting to get all elements.
-        // Then again, if and this is expanded to richer PDDL functionality (or if we want to allow extension.. - unlikely given the motivator for the project, but..).
+        // TODO-PERFORMANCE: Should perhaps store add and delete lists separately, for performance.
+        // Application and Regression are going to be far more common than wanting to get all elements.
+        // Then again, that would be problematic if this is ever expanded to richer PDDL functionality
+        // (or if we want to allow extension.. - unlikely given the motivator for the project, but..).
         // In any case, add some benchmarks before making any changes.
         public ImmutableHashSet<Literal> Elements { get; }
 

src/SCClassicalPlanning/Planning/GraphPlan/GraphPlan.cs

@@ -24,7 +24,7 @@ namespace SCClassicalPlanning.Planning.GraphPlan
     /// <para/>
     /// Extracts solutions via a backward search.
     /// </summary>
-    public class GraphPlan : IPlanner
+    internal class GraphPlan : IPlanner
     {
         /// <summary>
         /// Creates a (concretely-typed) planning task to work on solving a given problem.