Meteor Package support #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! To continue the discussion from gadicc/meteor-famous-views#186, I'm back from holidays and have reworked our code to use your library instead of using MutationObservers like we had before (thanks!).
The best way to do this is to have your code available as a Meteor package. Lately there has been a big effort in the community to get offical support from package authors directly rather than having a community member maintain a wrapper package that they need to keep up to date.
As per those guidelines, I'm submitting this PR for your consideration and have already registered "sdecima" as a meteor organization to expedite the process & testing. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account; unfortunately with a different username). After you've done that, please let me know the name of the account, and I'll add you as a maintainer. The package appears on Atmosphere thus: https://atmospherejs.com/sdecima/javascript-detect-element-resize.
Lastly, there is a script,
meteor/publish.sh, which you can run the same time asnpm publish(other authors have this integrated as part of their grunt-file / Makefile). Alternatively, the community is hard at work on a solution where on every push to github, the Meteor package is automatically built on and published from the cloud.Sorry for the long explanation and hope this all works for you :)