forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Device trees fixups for 6.13 #54
Open
minlexx
wants to merge
10
commits into
qcom-sdm660-6.13.y
Choose a base branch
from
qcom-sdm660-6.13.y-dt-fixes
base: qcom-sdm660-6.13.y
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+223
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f69945
to
77a4c08
Compare
Nokia 6.1 (nokia,pl2) is a smartphone based on SDM630 SoC. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Xiaomi Mi 8 Lite (xiaomi,platina) is a smartphone based on SDM660 SoC. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Asus Zenfone Max Pro M1 (asus,x00td) is a smartphone based on SDM636 SoC. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
77a4c08
to
543bead
Compare
Xiaomi Redmi Note 6 Pro (xiaomi,tulip) is a smartphone based on SDM636 SoC. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
543bead
to
5828868
Compare
Xiaomi Mi A2 (xiaomi,jasmine) is a smartphone based on SDM660 SoC. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
(not sure to which commit assign the fixups to, there was 2) Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
5828868
to
c3e0031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has some commits to our base
sdm630.dtsi
that enable more things by default and do some things differently than we had before.We need to remove/fixup nodes with status=okay which are now enabled by default:
adsp_pil
,anoc2_smmu
,gpucc
,kgsl_smmu
, andlpass_smmu
There is new separate label for adreno zap firmware node:
adreno_gpu_zap
. All GPU enablement should be done like in this commit: arm64: dts: qcom: sda660-ifc6560: enable GPU . In device DT separate enablement for adreno_gpu node and separate node for adreno_gpu_zap.For some/old dts also reorder nodes alphabetically and remove more unneed ones that are either already enabled or already disabled in parent .dtsi .
Fix several more dt-validate errors, like:
x.dtb: gpio-keys: 'vol_down', 'vol_up' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
(buttons should start with e.gkey-*
)gpio-hall-sensor: 'hall-sensor' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
node should be calledswitch
?gpio-key,wakeup
->wakeup-source
x.dtb: extcon-usb: 'id-gpio' does not match any of the regexes: 'pinctrl-[0-9]+'
(should beid-gpios
)*-state
, pin groups not ending with*-pins
function =
in pins spec, but function is required (assumedfunction = "gpio"
)The list of DTs to fix, strikeout ones that are already upstream:
sdm630-sony-xperia-nile.dtsisdm630-sony-xperia-nile-discovery.dtssdm630-sony-xperia-nile-pioneer.dtssdm630-sony-xperia-ganges-kirin.dtssdm630-sony-xperia-nile-voyager.dtssdm636-sony-xperia-ganges-mermaid.dtsFixes: #53