Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Device trees fixups for 6.13 #54

Open
wants to merge 10 commits into
base: qcom-sdm660-6.13.y
Choose a base branch
from

Conversation

minlexx
Copy link
Member

@minlexx minlexx commented Feb 7, 2025

Upstream has some commits to our base sdm630.dtsi that enable more things by default and do some things differently than we had before.

  1. We need to remove/fixup nodes with status=okay which are now enabled by default: adsp_pil, anoc2_smmu, gpucc, kgsl_smmu, and lpass_smmu

  2. There is new separate label for adreno zap firmware node: adreno_gpu_zap. All GPU enablement should be done like in this commit: arm64: dts: qcom: sda660-ifc6560: enable GPU . In device DT separate enablement for adreno_gpu node and separate node for adreno_gpu_zap.

For some/old dts also reorder nodes alphabetically and remove more unneed ones that are either already enabled or already disabled in parent .dtsi .

Fix several more dt-validate errors, like:

  • x.dtb: gpio-keys: 'vol_down', 'vol_up' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml# (buttons should start with e.g key-*)
  • gpio-hall-sensor: 'hall-sensor' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+' node should be called switch?
  • gpio-key,wakeup -> wakeup-source
  • x.dtb: extcon-usb: 'id-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' (should be id-gpios)
  • pinctrl subnodes not ending with *-state, pin groups not ending with *-pins
  • some were missing function = in pins spec, but function is required (assumed function = "gpio")

The list of DTs to fix, strikeout ones that are already upstream:

  • sdm630-nokia-pl2.dts
  • sdm630-sony-xperia-nile.dtsi
  • sdm630-sony-xperia-nile-discovery.dts
  • sdm630-sony-xperia-nile-pioneer.dts
  • sdm630-sony-xperia-ganges-kirin.dts
  • sdm630-sony-xperia-nile-voyager.dts
  • sdm636-asus-x00td.dts
  • sdm636-xiaomi-tulip.dts
  • sdm636-sony-xperia-ganges-mermaid.dts
  • sdm660-xiaomi-lavender-common.dtsi
  • sdm660-xiaomi-jasmine.dts
  • sdm660-xiaomi-clover-plus.dts
  • sdm660-xiaomi-clover.dts
  • sdm660-xiaomi-lavender-boe.dts
  • sdm660-xiaomi-clover-common.dtsi
  • sdm660-xiaomi-platina.dts
  • sdm660-xiaomi-lavender-tianma.dts

Fixes: #53

@minlexx minlexx changed the title WIP: Device trees fixups WIP: Device trees fixups for 6.13 Feb 7, 2025
@minlexx minlexx force-pushed the qcom-sdm660-6.13.y-dt-fixes branch 2 times, most recently from 7f69945 to 77a4c08 Compare February 8, 2025 10:54
Nokia 6.1 (nokia,pl2) is a smartphone based on SDM630 SoC.

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Xiaomi Mi 8 Lite (xiaomi,platina) is a smartphone based on SDM660 SoC.

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Asus Zenfone Max Pro M1 (asus,x00td) is a smartphone based on SDM636 SoC.

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
@minlexx minlexx force-pushed the qcom-sdm660-6.13.y-dt-fixes branch from 77a4c08 to 543bead Compare February 8, 2025 18:22
Xiaomi Redmi Note 6 Pro (xiaomi,tulip) is a smartphone based on SDM636 SoC.

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
@minlexx minlexx force-pushed the qcom-sdm660-6.13.y-dt-fixes branch from 543bead to 5828868 Compare February 9, 2025 07:24
Xiaomi Mi A2 (xiaomi,jasmine) is a smartphone based on SDM660 SoC.

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
(not sure to which commit assign the fixups to, there was 2)

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
@minlexx minlexx force-pushed the qcom-sdm660-6.13.y-dt-fixes branch from 5828868 to c3e0031 Compare February 9, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant