Alternative approach to checking cart #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdras
requested changes
Aug 23, 2019
✨ Remove void return in addToCart.
Is the last commit what you meant? And also, is it okay that I'm so active on the repo? I have the branches for issue #12 and issue #8 finished too, I just forgot to branch at the start, so they both include this PR.. I'll wait for your feedback before opening those PR's. :) |
|
Yep this is exactly what I meant! It's great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I had a look around in the project. It's awesome. I thought I'd contribute by suggesting an alternative Array method on the addToCart store mutation. It's minimal, but
findseems to perform better on tests I ran. (Array of objects size 1000).