-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sample codes #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must: take a look at the sh:in's generated for SHACL
probably nice: See why you are generating sh:nodeKind restrictions that may not be needed
pretty: regex's to further restrict some string props
Thanks, @rmfranken based on your inputs I've switched to making the values |
This is a first experiment with using dynamic enums to describe the range of a property. This does not appear to enforce much in the generated code, but my understanding is that (at least for now) this is mostly descriptive.
In our case, it should be OK as we control data entry.
The relevant change is in src/modos_schema/schema/modos_schema.yaml
It adds dynamic enums for cell types (cell ontology) and biological source material (uberon).