Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sample codes #16

Merged
merged 8 commits into from
Sep 24, 2024
Merged

feat: sample codes #16

merged 8 commits into from
Sep 24, 2024

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Sep 23, 2024

This is a first experiment with using dynamic enums to describe the range of a property. This does not appear to enforce much in the generated code, but my understanding is that (at least for now) this is mostly descriptive.

In our case, it should be OK as we control data entry.

The relevant change is in src/modos_schema/schema/modos_schema.yaml
It adds dynamic enums for cell types (cell ontology) and biological source material (uberon).

@cmdoret cmdoret self-assigned this Sep 23, 2024
@cmdoret cmdoret linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link
Member

@rmfranken rmfranken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must: take a look at the sh:in's generated for SHACL
probably nice: See why you are generating sh:nodeKind restrictions that may not be needed
pretty: regex's to further restrict some string props

project/shacl/modos_schema.shacl.ttl Outdated Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Outdated Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Outdated Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Outdated Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Outdated Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Show resolved Hide resolved
project/shacl/modos_schema.shacl.ttl Outdated Show resolved Hide resolved
src/modos_schema/schema/modos_schema.yaml Outdated Show resolved Hide resolved
@cmdoret
Copy link
Member Author

cmdoret commented Sep 24, 2024

Thanks, @rmfranken based on your inputs I've switched to making the values uriorcurie instead of using dynamic enums, and also enforced it for taxon ids (instead of integers).

@cmdoret cmdoret merged commit 1ec3973 into main Sep 24, 2024
2 checks passed
@cmdoret cmdoret deleted the feat/sample-codes branch October 7, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use standard code sets for sample properties
2 participants