Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: apply license and add contribution guide #15

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Nov 9, 2023

  • Apply GPL license headers
  • Add contributing guide
  • Add development section

@cmdoret cmdoret requested a review from caviri November 9, 2023 17:42
@cmdoret cmdoret self-assigned this Nov 9, 2023
@caviri
Copy link

caviri commented Nov 13, 2023

Hi @cmdoret I think it covers the basics for contributing guidelines. In the future we can add more instructions about which kind of tests should pass one branch before sending us the PR.

Also, another detail in the license:

// Copyright (C) 2023 - Swiss Data Science Center (SDSC)
// A partnership between École Polytechnique Fédérale de Lausanne (EPFL) and
// Eidgenössische Technische Hochschule Zürich (ETHZ).

Shouldn't the PSI appear here too? I'm not sure about this .

@cmdoret
Copy link
Member Author

cmdoret commented Nov 15, 2023

Thanks! Indeed, this information would be important! I"ll add it here so we have an example

For the license header, the EPFL page of SDSC PSI is indeed mentioned, but it still says "The Swiss Data Science Center (SDSC) is a joint venture between EPFL and ETH Zurich.". I guess we could keep it as-is at least for now.

@cmdoret cmdoret merged commit 5cd8136 into main Nov 15, 2023
1 check passed
@cmdoret cmdoret deleted the doc/apply-license branch November 15, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants