Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unitful support #23

Merged
merged 44 commits into from
Jan 16, 2025
Merged

Add Unitful support #23

merged 44 commits into from
Jan 16, 2025

Conversation

Eduardo-BDMAlves
Copy link
Contributor

This PR closes #21.

Unitful supported added as extension of the package. One thing that should be decided is if TransportPorpertyData should be exported since it is usefull to interact directly with it now.

Eduardo-BDMAlves and others added 30 commits January 2, 2025 22:02
@Eduardo-BDMAlves
Initial implementation of constructor with Unitful types for data inputs
9bf3fe0
@Eduardo-BDMAlves
Merge remote-tracking branch 'upstream/main'
b6f363a
@Eduardo-BDMAlves
Merge branch 'main' into feature/UnitfulSupport
bb5d9ed
@Eduardo-BDMAlves
Making extension compatible for some parameters with 0.3.0
1c95f94
@Eduardo-BDMAlves
Added data for actual properties in the constructor (forgot yesterday)
4c0cec0
@Eduardo-BDMAlves
Added missing second from Unitful imports.
3d67e72
@Eduardo-BDMAlves
Implemented interface for viscosity
5c0c10b
@Eduardo-BDMAlves
Added tests and corrected some bugs
45b69cf
@Eduardo-BDMAlves
Formatted files and added extra tests for units.
c35dfe5
@Eduardo-BDMAlves
Added extra properties and new constructor based in the TransportProp…
1d64cc5 
…erty
@Eduardo-BDMAlves
Added docs to functions and formated files
0efea45
@Eduardo-BDMAlves
Added example to Readme.md
0de99df
@se-schmitt
Restructuring and simplification of Unitful.jl extension
83fdb5f
@se-schmitt
Slight modification of TransportPropertyData constructor
4b413fe
@se-schmitt
Shorten unitful tests
46bdeb8
@se-schmitt
Remove old extension
2b4566f
@se-schmitt
Docs 'model constructors'
68790e7
@se-schmitt
Add references through DocumenterCitations.jl
c4c79f8
@se-schmitt
Revise Getting Started section
95ec6be
@se-schmitt
Revise models section
c28484d
@se-schmitt
Add bib file
e7b2ab7
@se-schmitt
Add citations style file
4bf03ce
@se-schmitt
Todo was done
ada2000
@se-schmitt
Removing todos
1f0b5b2
@se-schmitt
Add heat capacities to themo functions
170544c
@se-schmitt
Modification of Wilke to enable critical contribution
bf33af0
@se-schmitt
Fix typo
1733c79
@se-schmitt
First implementation of internal and critical contributions (not work…
e1cd973 
…ing!!)
@se-schmitt
change critical point function
21f36f4
@se-schmitt
Upload database
5fe6b00
@se-schmitt
Copy link
Owner

Hi Eduardo,
thanks a lot for your work, this is great! I modified your code a bit to simplify it while keeping the functionality. I also added a "Units" section to the docs and moved parts of the Readme file there. Additionally, the extension now supports mass densities for property calculations. I shortened the tests for the extension and hope it still covers all new Unitful methods. Any thoughts on the changes? Happy to merge it then.

@Eduardo-BDMAlves
Copy link
Contributor Author

Hi Sebastian,
The implementation is great, I didn't think to expand the properties and constructors that way, it is way smarter. As far as I tested the main functionalities are working and is good to merge!
If you need any help with the package in the future feel free to ask, would be happy to help.

@se-schmitt se-schmitt merged commit c445092 into se-schmitt:main Jan 16, 2025
5 checks passed
@se-schmitt
Copy link
Owner

Sure, I'm always happy about contributions. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Unitful.jl support
2 participants
@Eduardo-BDMAlves @se-schmitt