Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for trogon. #870

Open
wants to merge 13 commits into
base: vara-dev
Choose a base branch
from
Open

Adds support for trogon. #870

wants to merge 13 commits into from

Conversation

boehmseb
Copy link
Member

@boehmseb boehmseb commented Jan 5, 2024

Most vara-* commands now support tui as a subcommand which opens a text-based UI for selecting command line parameters.

Some limitations apply:

Most vara-* commands now support `tui` as a subcommand which opens a text-based UI for selecting command line parameters.
@boehmseb boehmseb requested a review from LuAbelt January 6, 2024 15:27
Copy link
Contributor

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand this correctly, this is "opt-in" as in one can use the CLI as is, without changes and if wanted with the clicky UI?

PS: also some tests seem not to be happy :D

Comment on lines -92 to -102
get_value_or_default(
vara_cfg()["paper_config"], "folder",
str(get_varats_base_folder())
)
)
if not (pc_folder_path.exists() and pc_folder_path.is_dir()):
LOG.error(
f"Paper config folder not set: {pc_folder_path} "
"(Path does not exist or is no directory)."
)
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer need the checks here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because by now we take care of creating these directories whenever we save the config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the config folder has a sane default value set.

@boehmseb
Copy link
Member Author

boehmseb commented Jan 7, 2024

Do I understand this correctly, this is "opt-in" as in one can use the CLI as is, without changes and if wanted with the clicky UI?

Yes, this basically adds a new subcommand tui to each supported tool that starts the text-based UI (bonus points for a good idea where/how to document this).

PS: also some tests seem not to be happy :D

I have no idea why. That test initially also failed on my machine but for a different reason. All tests pass when I execute them locally.

The reason for the failing test was that the CLI parameters are generated at parse-time. Since the test modified the available choices of such an option, we need to reload the driver module for that change to take effect at the CLI level.
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (991bb76) 68.43% compared to head (9ed2424) 68.45%.

Files Patch % Lines
varats/varats/tools/driver_artefacts.py 96.15% 1 Missing ⚠️
varats/varats/tools/driver_casestudy.py 95.65% 1 Missing ⚠️
varats/varats/tools/driver_paper_config.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           vara-dev     #870      +/-   ##
============================================
+ Coverage     68.43%   68.45%   +0.02%     
============================================
  Files           340      340              
  Lines         26627    26635       +8     
============================================
+ Hits          18221    18233      +12     
+ Misses         8406     8402       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants