-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added real world regression for HyTeg
- Loading branch information
Lukas Abelt
committed
Feb 21, 2024
1 parent
38df472
commit fbefcb9
Showing
2 changed files
with
105 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| description: A regression to the HyTeG project that could be introduced due to a "bad" commit by an inexperienced developer. | ||
| include_revisions: | ||
| revision_range: | ||
| start: f4711dadc3f61386e6ccdc704baa783253332db2 | ||
| path: bad-commit.patch | ||
| project_name: HyTeg | ||
| shortname: bad-commit | ||
| tags: | ||
| - HyTeg | ||
| - compile-time | ||
| - regression | ||
| - perf_prec | ||
| - real_world |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| diff --git a/src/hyteg/p1functionspace/P1Operator.hpp b/src/hyteg/p1functionspace/P1Operator.hpp | ||
| index 2e110ff2c..8b1e61cf3 100644 | ||
| --- a/src/hyteg/p1functionspace/P1Operator.hpp | ||
| +++ b/src/hyteg/p1functionspace/P1Operator.hpp | ||
| @@ -266,25 +266,11 @@ class P1Operator : public Operator< P1Function< ValueType >, P1Function< ValueTy | ||
| { | ||
| if ( storage_->hasGlobalCells() ) | ||
| { | ||
| - if ( hyteg::globalDefines::useGeneratedKernels ) | ||
| - { | ||
| - apply_face3D_generated( face, src.getFaceDataID(), dst.getFaceDataID(), level, updateType ); | ||
| - } | ||
| - else | ||
| - { | ||
| - apply_face3D( face, src.getFaceDataID(), dst.getFaceDataID(), level, updateType ); | ||
| - } | ||
| + apply_face3D( face, src.getFaceDataID(), dst.getFaceDataID(), level, updateType ); | ||
| } | ||
| else | ||
| { | ||
| - if constexpr ( hyteg::globalDefines::useGeneratedKernels ) | ||
| - { | ||
| - apply_face_generated( face, src.getFaceDataID(), dst.getFaceDataID(), level, updateType ); | ||
| - } | ||
| - else | ||
| - { | ||
| - apply_face( face, src.getFaceDataID(), dst.getFaceDataID(), level, updateType ); | ||
| - } | ||
| + apply_face( face, src.getFaceDataID(), dst.getFaceDataID(), level, updateType ); | ||
| } | ||
| } | ||
| } | ||
| @@ -306,14 +292,7 @@ class P1Operator : public Operator< P1Function< ValueType >, P1Function< ValueTy | ||
|
|
||
| if ( testFlag( cellBC, flag ) ) | ||
| { | ||
| - if constexpr ( hyteg::globalDefines::useGeneratedKernels ) | ||
| - { | ||
| - apply_cell_generated( cell, src.getCellDataID(), dst.getCellDataID(), level, updateType ); | ||
| - } | ||
| - else | ||
| - { | ||
| - apply_cell( cell, src.getCellDataID(), dst.getCellDataID(), level, updateType ); | ||
| - } | ||
| + apply_cell( cell, src.getCellDataID(), dst.getCellDataID(), level, updateType ); | ||
| } | ||
| } | ||
| } | ||
| @@ -984,25 +963,11 @@ class P1Operator : public Operator< P1Function< ValueType >, P1Function< ValueTy | ||
| { | ||
| if ( storage_->hasGlobalCells() ) | ||
| { | ||
| - if ( globalDefines::useGeneratedKernels ) | ||
| - { | ||
| - smooth_sor_face3D_generated( face, dst.getFaceDataID(), rhs.getFaceDataID(), level, relax, backwards ); | ||
| - } | ||
| - else | ||
| - { | ||
| - smooth_sor_face3D( face, dst.getFaceDataID(), rhs.getFaceDataID(), level, relax, backwards ); | ||
| - } | ||
| + smooth_sor_face3D( face, dst.getFaceDataID(), rhs.getFaceDataID(), level, relax, backwards ); | ||
| } | ||
| else | ||
| { | ||
| - if ( globalDefines::useGeneratedKernels ) | ||
| - { | ||
| - smooth_sor_face_generated( face, dst.getFaceDataID(), rhs.getFaceDataID(), level, relax, backwards ); | ||
| - } | ||
| - else | ||
| - { | ||
| - smooth_sor_face( face, dst.getFaceDataID(), rhs.getFaceDataID(), level, relax, backwards ); | ||
| - } | ||
| + smooth_sor_face( face, dst.getFaceDataID(), rhs.getFaceDataID(), level, relax, backwards ); | ||
| } | ||
| } | ||
| } | ||
| @@ -1027,14 +992,7 @@ class P1Operator : public Operator< P1Function< ValueType >, P1Function< ValueTy | ||
|
|
||
| if ( testFlag( cellBC, flag ) ) | ||
| { | ||
| - if ( globalDefines::useGeneratedKernels ) | ||
| - { | ||
| - smooth_sor_cell_generated( cell, dst.getCellDataID(), rhs.getCellDataID(), level, relax, backwards ); | ||
| - } | ||
| - else | ||
| - { | ||
| - smooth_sor_cell( cell, dst.getCellDataID(), rhs.getCellDataID(), level, relax, backwards ); | ||
| - } | ||
| + smooth_sor_cell( cell, dst.getCellDataID(), rhs.getCellDataID(), level, relax, backwards ); | ||
| } | ||
| } | ||
|
|