-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates: fix mismatched type size in simple #140
Conversation
Based on seL4/util_libs#176 (comment) it seems |
Yes, we can just use |
Fix a mismatched type size error in component.simple.c:485, which may causes data overflow when CONFIG_WORD_SIZE is 64 in the 64-bit machine. Using defined CLZL() macro to correctly handle the specified CONFIG_WORD_SIZE. Signed-off-by: colorglass <55863235+colorglass@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
You may want to raise an issue separately for supporting the LLP64 data model for 64-bit userland. Seem not many people have tries doing this using the "Windows" compiler.
Sorry for my bothering. |
The error in the build seems to be
The syntax looks correct to me, but the compiler seems to disagree :-). Might need to track down the Edit: just saw that is this is not even part of your change. Including |
😢 Its my shame that I forgot to add the corresponded header file in that PR commit. And it was closed without the fix. |
The "Test with" was still in the PR description when this was pushed. Removed now and re-running, so CI will just use this PR and not the other one also. |
Good catch, thanks @axel-h. The link checker is unhappy with graphviz for some reason today, but that is unrelated. Good to merge from my side. |
Thanks for the contribution, @colorglass |
Fix this #139. Using macro to select the build-in function in different type size.
For more background and discussion see also seL4/util_libs#176