-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARMv6 is no longer supported by seL4 #39
Conversation
Looks like |
Seem it's some more work, lots of referenced actually... |
I've done some dumb replacement now and the build should work again. The binary |
I wonder, should we add |
f3ffc75
to
3c92322
Compare
I'd leave ARM_HYP as future task, esp since we want to get away from treating hyp as a separate architecture (not sure it'll be possible, but it'd be nice). @corlewis do you have any thoughts on this? The other thing we will need to look at/change is all upstream code in other repos that produces those capDL specs. They will likely still reference |
Is this why the " / capDL-tool (ghc)" fails:
or am I missing something? |
I think you're right, we might need to add graphviz to the install in the action. Strange that this hasn't triggered before. |
"arm11" is the capdl spec name that is used for aarch32 configurations. The biggest reason to keep accepting "arm11" is that it's what's always been used and it isn't causing any issues. The spec definition currently accepts one name for each architecture it understands which is quite simple. |
@kent-mcleod: Based on you comment, should I drop this PR and make a new one that just adds comment explaining what this still exists? That should be sufficient to demystify things for anybody stumbling over this. |
That would be the minimal solution. I'm Ok with that, and this is really not high priority, but it'd be nice fix this name at least eventually (it's kinda my fault, I introduced it in the very beginning of capDL when verification supported only Arm11 and nothing else). I'd be perfectly fine with the tool understanding both and producing a deprecation warning for |
Ok, See #40 |
363a995
to
80cfee2
Compare
b33cc89
to
cffbe67
Compare
561550c
to
f6d6cbb
Compare
- remove trailing spaces - add linebreaks at end of file Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
With seL4/seL4#580 the ARMv6 support has been removed. Thus there's no reason to accept "arm11" here any longer.