remove valid_arch_mdb_ctes #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This invariant is currently proved on the Haskell level only. This commit is in preparation of removing the invariant from the Haskell level, crossing it over via assertions. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Introduce the name and assertion "archMDBAssertions" in cteInsert so that specific architectures can make additional MDB assumptions (e.g. IOControlPortCap uniqueness in X64). Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
- replace the ioport_control invariant with archMDBAssertions - remove lemmas needed only for the invariant - add corresponding crossing lemmas for caps_of_state based on existing older cte_wp_at lemmas Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
lsf37
added
the
arch-split
Actually, it is better to do it the other way around. I haven't applied the changes to RISCV64 here, because that one doesn't work yet, but they are probably much easier to apply after RISCV64 is split than trying to get the split to work on things that are broken because of the changes here. So RISCV64 split without this PR first, then I can adjust this PR, and then everything should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross over the contents of
valid_arch_mdb_ctesfrom the abstract side after proving the missing bits as invariants.Introduces the assertion
archMDBAssertionsin Haskell, which is defined generically asarch_mdb_assert (ctes_of s).arch_mdb_assertin turn is architecture dependent andTrueanywhere that is not X64.This took quite a bit longer than I had anticipated, and doesn't actually remove that many lines of proof, but it hopefully removes many annoying lines that we would have had to write in the future for arch split to continue. So overall still worth it, I think.
This is on top of PR #847 -- when we start RISCV64 that should probably go on top of this work to avoid duplication.