Change to support BSD sed #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwin-joshy
force-pushed
the
macos_touch
branch
3 times, most recently
from
860234d
to
688db1b
Compare
|
The other two changes are unrelated but were required to get style checks passing. |
| @@ -72,6 +72,11 @@ if(LibPicotcp) | |||
| add_custom_target(get_muslc) | |||
| add_dependencies(get_muslc muslc) | |||
|
|
|||
| set(sed_inplace_suffix "") | |||
There was a problem hiding this comment.
Need a comment explaining why the behaviour is needed on macOS.
There was a problem hiding this comment.
Yes, a comment here would be nice
lsf37
reviewed
Sep 11, 2023
alwin-joshy
force-pushed
the
macos_touch
branch
2 times, most recently
from
ed13149
to
78e59c6
Compare
Signed-off-by: Alwin Joshy <joshyalwin@gmail.com>
alwin-joshy
force-pushed
the
macos_touch
branch
from
78e59c6
to
f670f46
Compare
lsf37
approved these changes
Sep 11, 2023
Ivan-Velickovic
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GNU
sed, the suffix is optional for the-iargument, but is mandatory for the BSDsedshipped with MacOS. This change checks whether the host is an Apple system and if so, supplies a suffix.