Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morello: Add support for QEMU platform #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

morello: Add support for QEMU platform #172

wants to merge 1 commit into from

Conversation

heshamelmatary
Copy link
Contributor

@heshamelmatary heshamelmatary commented Jan 11, 2024 •
edited
Loading

This was tested on a baseline AArch64 Morello/QEMU without CHERI.

Basic support for a PL011 driver.

@heshamelmatary heshamelmatary mentioned this pull request Jan 11, 2024
Open
33 tasks
@axel-h
Copy link
Member

axel-h commented Jan 11, 2024

Do you expect this to match the hardware, so we'd put this in a morello folder and not morello-qemu

@axel-h
Copy link
Member

axel-h commented Jan 11, 2024

Since this created another PL011 driver, it could be put on top of #157 to reduce the duplication a bit.

@heshamelmatary
Copy link
Contributor Author

heshamelmatary commented Jan 11, 2024 •
edited
Loading

Do you expect this to match the hardware, so we'd put this in a morello folder and not morello-qemu

Not quite. PL011's address and IRQ are different. Also hardware has extra clock, pl011, and timer (SP804) drivers. Unfortunately, I don't think drivers can be currently shared in util_libs.

@heshamelmatary
Copy link
Contributor Author

Since this created another PL011 driver, it could be put on top of #157 to reduce the duplication a bit.

I believe that's the right direction, but are there plans to merge #157 soon? If not, we could just merge this and then remove later not to block seL4/seL4#1158 ?

@heshamelmatary
morello: Add support for QEMU platform
8b2be6c 
This was tested on a baseline AArch64 Morello/QEMU without CHERI.
Basic support for a PL011 driver.

Signed-off-by: Hesham Almatary <hesham.almatary@cl.cam.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel-h axel-h axel-h left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heshamelmatary @axel-h