Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-builder): Add http2_max_header_list_size to the client builder #2465

Conversation

DSharifi
Copy link
Contributor

@DSharifi DSharifi commented Oct 29, 2024

Currently the max size of received header frames for HTTP2 responses defaults to the 16KB when creating a hyper client. The 16KB default is defined in hyper::proto::h2::DEFAULT_MAX_HEADER_LIST_SIZE.

This PR adds support to override this default value, to allow for custom limits of the maximum header sizes being received in HTTP/2 responses.

@DSharifi DSharifi marked this pull request as ready for review October 29, 2024 12:28
@seanmonstar
Copy link
Owner

I'd be happy to add this. Looks like CI noticed that we need to bump the minimal version of hyper-util to use this.

… github.com:DSharifi/reqwest into dsharifi/add-max-header-list-size-to-client-builder
@DSharifi
Copy link
Contributor Author

Thanks. Bumped the hyper util dependency version to 0.1.10.

@seanmonstar seanmonstar merged commit 3f28983 into seanmonstar:master Oct 29, 2024
36 checks passed
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants