Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exists_ok and force flags to create_table #34

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented Sep 27, 2024

  • add exists= flag to the create_table method.
    • this defaults to True and will silently ignore a table if it already exists. If you set to False, it will instead raise a TableCreationError
  • add force= flag to the create_table method.
    • this defaults to False. If set to True , it will explicitly drop then re-create the table.

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan self-assigned this Sep 27, 2024
@seapagan seapagan added the enhancement New feature or request label Sep 27, 2024
Copy link

codacy-production bot commented Sep 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cdd369e) 506 499 98.62%
Head commit (0ad2f67) 522 (+16) 515 (+16) 98.66% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#34) 17 17 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan changed the title Add exists_ok to create_table Add exists_ok and force flags to create_table Sep 27, 2024
@seapagan seapagan force-pushed the add-create_table-flags branch from 83fc7b3 to e55a376 Compare September 27, 2024 18:45
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan force-pushed the add-create_table-flags branch from e55a376 to 0ad2f67 Compare September 27, 2024 18:46
@seapagan seapagan marked this pull request as ready for review September 27, 2024 18:47
@seapagan seapagan merged commit e18d870 into main Sep 27, 2024
11 checks passed
@seapagan seapagan deleted the add-create_table-flags branch September 27, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant