Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue # 37, wip, has issues #38

Closed
wants to merge 2 commits into from
Closed

Fix issue # 37, wip, has issues #38

wants to merge 2 commits into from

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented Sep 29, 2024

working on this bug is exposing other issues that need fixed to get this to work

seapagan and others added 2 commits September 28, 2024 11:48
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.29% (target: -1.00%) 36.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (627dea1) 522 515 98.66%
Head commit (57a6098) 533 (+11) 519 (+4) 97.37% (-1.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#38) 11 4 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codacy-production bot commented Sep 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.29% (target: -1.00%) 36.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1e4af95) 522 515 98.66%
Head commit (57a6098) 533 (+11) 519 (+4) 97.37% (-1.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#38) 11 4 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@seapagan seapagan changed the title wip, has issues Fix issue # 37, wip, has issues Sep 29, 2024
@seapagan seapagan self-assigned this Sep 29, 2024
@seapagan seapagan added the bug Something isn't working label Sep 29, 2024
@seapagan
Copy link
Owner Author

This will most-likely be replaced by #39 since it makes much more sense to always have an auyo-increment key.

In future releases it is very likely this can be made optional again, but i want to get the default behavior properly implemented

@seapagan
Copy link
Owner Author

seapagan commented Sep 30, 2024

close, this is now irrelevant d/t #39

@seapagan seapagan closed this Sep 30, 2024
@seapagan seapagan deleted the fix-bug-37 branch September 30, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant