Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing commits from the previous PR (#49) #50

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Fix missing commits from the previous PR (#49) #50

merged 4 commits into from
Oct 13, 2024

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented Oct 13, 2024 •
edited
Loading

These 4 commits were not pushed before the PR was merged 🤦‍♂️

@seapagan
allow custom timestamps to be created on insert() only
b7c8757 
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan
gate the ability to specify timestamps on create
a903d64 
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan
add a test to ensure timestamps are in UTC
c26bca8 
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan
update docs for timestamps
9afc8e4 
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan added the invalid This doesn't seem right label Oct 13, 2024
@seapagan seapagan self-assigned this Oct 13, 2024
@seapagan seapagan added bug Something isn't working and removed invalid This doesn't seem right labels Oct 13, 2024
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.01% (target: -1.00%) ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ffde9e9) 598 591 98.83%
Head commit (9afc8e4) 603 (+5) 596 (+5) 98.84% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#50) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

1 similar comment
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.01% (target: -1.00%) ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ffde9e9) 598 591 98.83%
Head commit (9afc8e4) 603 (+5) 596 (+5) 98.84% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#50) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@seapagan seapagan marked this pull request as ready for review October 13, 2024 15:39
@seapagan seapagan merged commit 87d0f55 into main Oct 13, 2024
11 of 12 checks passed
@seapagan seapagan deleted the fix-missing-commits branch October 13, 2024 15:39
@seapagan seapagan changed the title Fix missing commits from the previous PR (#) Fix missing commits from the previous PR (#49) Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seapagan seapagan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seapagan