Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance: ask a few questions. #26

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Add instance: ask a few questions. #26

merged 3 commits into from
Mar 26, 2020

Conversation

dalf
Copy link
Contributor

@dalf dalf commented Mar 23, 2020

@dalf
Copy link
Contributor Author

dalf commented Mar 23, 2020

request for comments
@asciimoo @unixfox @return42 @Pofilo @caribpa


searx.space source code: https://github.com/dalf/searx-stats2

If you have modified searx, please provide an URL to the source code, either here or in the theme of your instance.
Copy link

@caribpa caribpa Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the AGPLv3 those who modify the source code must have a public URL in their site to their full code. Thus I'd suggest to change this text to:

If you have modified searx, please provide a URL to the source code and make sure that the same URL is publicly accessible in your instance's site.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the question "My instance runs unmodified searx source code.". It seems an yes answer is mandatory to get the instance accepted.

About LGPL: I think it should be solve in the searx project, but a reminder here won't hurt, so I added the text you have suggested.

@return42
Copy link
Contributor

I do not have any special meaning about .. since checking is elementary for a stat and user came to add there instance to that stat I do not see the need for a special agreement. Are there really users having such problems with?

Anyway the comments you made in the patch are clarifying things more up .. you got my votes up :)

.github/ISSUE_TEMPLATE/add-instance.md Outdated Show resolved Hide resolved
…rx source code."

Add searx.space IP addresses
<!-- please answer the following questions (replace [ ] by [x] to say yes) -->
* [ ] It is my instance.
* [ ] I agree searx.space to check my instance (every 3 hours for the response times, every 24 hours for the other tests).
* [ ] My instance runs unmodified searx source code.

This comment was marked as resolved.

@dalf dalf merged commit 784838c into master Mar 26, 2020
@dalf dalf deleted the a_few_questions branch June 11, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User agreement
5 participants